fix memory leak in error path

5 years ago · 1544cf006c
parent 2389a150ac
commit 1544cf006c
1 changed files with 6 additions and 3 deletions
--- a/cdb/cdb_make.c
+++ b/cdb/cdb_make.c
@ -46,9 +46,12 @@ int cdb_make_addend(struct cdb_make *c,unsigned long int keylen,unsigned long in
  head->hp[head->num].p = c->pos;
  ++head->num;
  ++c->numentries;
-  if (posplus(c,8) == -1) return -1;
-  if (posplus(c,keylen) == -1) return -1;
-  if (posplus(c,datalen) == -1) return -1;
+  if (posplus(c,8) == -1 ||
+      posplus(c,keylen) == -1 ||
+      posplus(c,datalen) == -1) {
+    free(head);
+    return -1;
+  }
  return 0;
 }